Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outputs now updating correctly when output items are updated. #13023

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jonah-iden
Copy link
Contributor

What it does

Fixes #13019

Firstly this fixes that output rendering is updated correctly when ouptut items changed.
Secondly this adds vscodes feature which concatinates stdOut and stdErr output items together.
The compression vscode is doing there is not implemented though.

How to test

create a notebook with a code cell like the following

import time
print('1')

time.sleep(1)

print('2')

time.sleep(1)

print('3')

execute the cell and see how all outputs appear one after the other

Follow-ups

Review checklist

Reminder for reviewers

Stdout and StdError output items are concatinated

Signed-off-by: Jonah Iden <[email protected]>
@msujew msujew added the notebook issues related to notebooks label Oct 24, 2023
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, code looks good and the change fixes the issue at hand 👍

@jonah-iden jonah-iden merged commit e4356c3 into master Oct 24, 2023
12 of 13 checks passed
@github-actions github-actions bot added this to the 1.43.0 milestone Oct 24, 2023
@msujew msujew deleted the jiden/13019-fix-outputs-updating-correctly branch October 24, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Notebooks: Cell output is not displayed after time interval
2 participants